Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: improve vector output support for contracts #1183

Merged
merged 51 commits into from
Aug 23, 2023
Merged

feat!: improve vector output support for contracts #1183

merged 51 commits into from
Aug 23, 2023

Conversation

camsjams
Copy link
Contributor

@camsjams camsjams commented Aug 14, 2023 •
edited
Loading

This adds additional level of support, see details in #933

Previous Vector support

Currently (on master) we support:

  • u8
  • u16
  • u32
  • u64

See also follow up for bytes: #1188
See also follow up for Multicalls with Vector output: #1189 / #1192

Closes #933

@camsjams camsjams self-assigned this Aug 14, 2023
@nedsalk nedsalk self-requested a review August 22, 2023 13:30
nedsalk
nedsalk previously approved these changes Aug 22, 2023
View reviewed changes
@nedsalk nedsalk self-requested a review August 22, 2023 13:30
@nedsalk nedsalk dismissed their stale review August 22, 2023 13:32

It automatically approved when I removed the "request changes" status, which isn't what I wanted.

nedsalk
nedsalk reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things that I understand look good to me. I've just added some questions, suggested changes and ideas. I can't comment much on the usage of fuel-asm as it's not fully familiar to me, but it obviously works given that the tests are passing :).

Dhaiwat10
Dhaiwat10 previously approved these changes Aug 22, 2023
View reviewed changes
nedsalk
nedsalk previously approved these changes Aug 22, 2023
View reviewed changes
@camsjams camsjams dismissed stale reviews from nedsalk and Dhaiwat10 via 7118a7d August 23, 2023 04:52
@camsjams camsjams requested review from nedsalk and Dhaiwat10 August 23, 2023 05:07
@camsjams camsjams merged commit a8234c3 into master Aug 23, 2023
@camsjams camsjams deleted the cm/issue-933-new branch August 23, 2023 09:44
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Merged
@Torres-ssf Torres-ssf mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@camsjams camsjams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Vector output support with Vec<> return
3 participants
@camsjams @nedsalk @Dhaiwat10